search

bryant / argon2rs

The pure-Rust password hashing library running on Argon2.
MIT License
174 stars 19 forks source link

Run tests in all Rust channels #6

Closed upsuper closed 7 years ago

bryant commented 8 years ago

Rather than adding a separate feature flag, I'm considering placing the constant_eq tests (they're not really benchmarks, per se) in their own module under $ROOT/benches so that they're still accessible via cargo bench with the right rustc: https://github.com/bryant/argon2rs/pull/7 . Let me know your thoughts on that.

However, I would still like to merge the changes you've made to .travis.yml, so would you mind rebasing your changes off #7?

upsuper commented 8 years ago

Could you merge that first?

Also conditionally running benchmarks could be a bit challenging. I'm not quite familiar with travis. Probably your current method is fine enough, and the only thing left is adding beta to the list.

I'm not quite sure whether running benchmark test on travis is a good idea, though.

bryant commented 8 years ago

Done.

bryant commented 7 years ago

I think this was fixed by https://github.com/bryant/argon2rs/commit/cfe2fac1bb0a8f896bac0732a0bbb0aac020925c and https://github.com/bryant/argon2rs/commit/2ed4cadce2bca8e7e785d4333d6d3d2004871367 . Feel free to re-open this if you spot any problems.