search

bryanthowell-tableau / tableau_tools

Package containing Tableau REST API, XML modification, tabcmd and repository tools
Other
214 stars 87 forks source link

NameError: name 'wbp_name_or_luid' is not defined in query_workbook() #36

Closed awithey-sedex closed 6 years ago

awithey-sedex commented 6 years ago

If you call query_workbook() with a p_name_or_luid set to a luid, then you get the python error: NameError: name 'wbp_name_or_luid' is not defined

This is caused by a typo in tableau_rest_api_connection.py, line 838: wb_in_proj = workbooks.findall('.//t:workbook[@name="{}"]/:project[@id="{}"]/..'.format(wbp_name_or_luid), self.ns_map)

see: https://github.com/bryantbhowell/tableau_tools/blob/f64a04a8b5d79807bd12a03459508b377462c92b/tableau_rest_api/tableau_rest_api_connection.py#L838

awithey-sedex commented 6 years ago

PS: The parameter name p_name_or_luid is different from query_datasource, which uses proj_name_or_luid

bryanthowell-tableau commented 6 years ago

Andrew, Thank you for finding this, the fix will be in the 4.6.0 release sometime soon. I've already committed them up to see in GitHub. I also updated the p_name_or_luids to proj_name_or_luids throughout the library, which hopefully won't break anything, but I incremented the minor point number just in case.