search

bryanthowell-tableau / tableau_tools

Package containing Tableau REST API, XML modification, tabcmd and repository tools
Other
215 stars 86 forks source link

Fix query_workbooks_in_project when using project luid #6

Closed scenting closed 8 years ago

scenting commented 8 years ago

Hi,

This fixes the issue #5. There was a problem as the code was querying a project and assigning it to a variable as it was project_luid. An alternative solution is to properly assign the id of the newly retrieved project to the variable, something as:

project_luid = self.query_project_by_luid(project_name_or_luid).get('id')

But I prefer solution as one request to the server is saved.

bryanthowell-tableau commented 8 years ago

Thank you for finding this. I've got it update in the main branch and the fix will be included with the next update.

scenting commented 8 years ago

Hi,

Just as feedback, what do you think is the best solution? The one on the PR or the one proposed in comments? I can prepare pull requests with either one of them.