search

bryanwee023 / pe

0 stars 0 forks source link

Unexpected flags can be registered inappropriately #2

Open bryanwee023 opened 3 years ago

bryanwee023 commented 3 years ago

When I add a flag -df into the programme, it registers it as a d flag, and assumes "f" to be part of the description. I think it would be more appropriate if the useris flagged with an error instead.

image.png

nus-pe-bot commented 2 years ago

Team's Response

Same issue as #4929. Wrong expectation of CLI flag behaviour.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Recipe commands with invalid command flags are accepted

Applies to all command flags used for recipe commands

To reproduce:

  1. Edit a recipe with the command edit recipe 2 -s1234 -s4567

Expected:

  • An error message informing users that the command flag is invalid

Actual:

  • Result pictured in the screenshot below

image.png

Users who make minor typos will be affected, and will cause some inconvenience as they would have to enter in all of their information again.

[original: nus-cs2103-AY2122S1/pe-interim#4926] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

I understand this issue as the tester believes there should be a space between the command flag and the actual input. However, in CLI convention, that is not necessary. For example, to compile a C program using gcc, we can use command gcc -otest test.c. Given our target audience is familiar with CLI, this should not come as a surprise, therefore it is not a bug but a feature.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Medium] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]