search

bryanwweber / thermostate

State Manager for Thermodynamic Properties
https://thermostate.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
10 stars 19 forks source link

Default Units #35

Closed jaredmlobo closed 3 years ago

jaredmlobo commented 3 years ago

Added the ability to set default units, both for the individual class, and within the global namespace for any new class initialized

Changes proposed in this pull request: -added default units

-

codecov[bot] commented 3 years ago

Codecov Report

Merging #35 (ae95c13) into main (7b7967b) will increase coverage by 0.23%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   96.79%   97.02%   +0.23%     
==========================================
  Files           4        4              
  Lines         374      404      +30     
  Branches       88       95       +7     
==========================================
+ Hits          362      392      +30     
  Misses          5        5              
  Partials        7        7
Impacted Files Coverage Δ
src/thermostate/__init__.py 100.00% <100.00%> (ø)
src/thermostate/abbreviations.py 100.00% <100.00%> (ø)
src/thermostate/thermostate.py 98.90% <100.00%> (+0.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b7967b...ae95c13. Read the comment docs.

jaredmlobo commented 3 years ago

@bryanwweber Thank you very much! I believe I've fixed all of the errors, it is still showing that there are changes requested but I believe I resolved all the conversations and don't know where to look. I will email you about setting up a meeting time for this week.