search

bryanyang0528 / ksql-python

A python wrapper for the KSQL REST API.
MIT License
159 stars 67 forks source link

add tests and fix json parsing error in process_row function #105

Closed Bradleywboggs closed 2 years ago

Bradleywboggs commented 2 years ago

For pull queries, the last row of results may have a trailing closing bracket, ], which causes json.loads to fail. This PR adds tests which were used to verify the issue and small code change to fix it.

codecov[bot] commented 2 years ago

Codecov Report

Merging #105 (dbda097) into master (71f112f) will increase coverage by 0.20%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   66.45%   66.66%   +0.20%     
==========================================
  Files           7        7              
  Lines         480      480              
  Branches       82       82              
==========================================
+ Hits          319      320       +1     
  Misses        141      141              
+ Partials       20       19       -1
Impacted Files Coverage Δ
ksql/utils.py 83.95% <100.00%> (+1.23%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

bryanyang0528 commented 2 years ago

@Bradleywboggs Thank you for the contribution and for increasing test coverage.

bryanyang0528 commented 2 years ago

@KenCox94 LGTM. Thank you!