bryanyang0528 / ksql-python

A python wrapper for the KSQL REST API.
MIT License
159 stars 67 forks source link

Fix StopIteration runtime error from generator for Python > 3.6.x #121

Open dragostreltov opened 1 year ago

dragostreltov commented 1 year ago

Hello,

I've been testing the app and discovered it throws runtime errors during execution of any query when using Python > 3.6.x (with 3.5.x - 3.6.x was working fine):

image

I fixed the issue by using explicit iteration over subgenerators. Now the app works as expected with Python 3.5.x - 3.9.x.


Mentions:

However, I also discovered the app does not work with Python >= 3.10.x because:

The Iterable abstract class was removed from collections in Python 3.10.x

Which is used by hyper here

from hyper import HTTPConnection

Hyper lib is very old and no longer maintained since 3 years ago. In order to fix this, I'd suggest refactoring all instances of hyper(HTTPConnection) by using requests lib.