search

bryanyang0528 / ksql-python

A python wrapper for the KSQL REST API.
MIT License
159 stars 64 forks source link

Uploadfiles #30

Closed bryanyang0528 closed 6 years ago

bryanyang0528 commented 6 years ago

I'll add basic test case for passing the check

codecov[bot] commented 6 years ago

Codecov Report

Merging #30 into master will decrease coverage by 12.39%. The diff coverage is 36.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage    90.9%   78.51%   -12.4%     
==========================================
  Files           5        6       +1     
  Lines         231      270      +39     
  Branches       26       33       +7     
==========================================
+ Hits          210      212       +2     
- Misses         13       48      +35     
- Partials        8       10       +2
Impacted Files Coverage Δ
ksql/upload.py 0% <0%> (ø)
ksql/builder.py 91.11% <100%> (ø) :arrow_up:
ksql/client.py 82.35% <44.44%> (-11.2%) :arrow_down:
ksql/errors.py 90.9% <66.66%> (-9.1%) :arrow_down:
ksql/api.py 86.2% <80%> (-1.15%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8eaab4b...e1ec4e5. Read the comment docs.

bryanyang0528 commented 6 years ago

@maulikjs Because get_ksql_version in init function will cause test cases failed, I add a tag to turn on/off it and modify related test cases.

validate_sql_string function is the key of sql builder for , so I modify it for compatible to current sql builder.