bbkchdhry commented 4 years ago

Hi team,

I am using ksql 0.10.1.1 version and it doesn't throw any error if I execute a wrong command. But for the same code with previous ksql version 0.5.1.1 it shows the error.

My Code:

Error from ksql: 0.5.1.1

Result from ksql: 0.10.1.1

So, I have modified the code a little and now the exception handling is working fine.

codecov[bot] commented 4 years ago

Codecov Report

Merging #81 into master will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   74.65%   74.65%           
=======================================
  Files           7        7           
  Lines         363      363           
  Branches       48       48           
=======================================
  Hits          271      271           
  Misses         77       77           
  Partials       15       15

Impacted Files	Coverage Δ
ksql/api.py	`70.54% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 81e0886...33c8be3. Read the comment docs.

bryanyang0528 commented 4 years ago

@bbkchdhry Thanks. That's exactly what I would like to fix too.

bryanyang0528 / ksql-python

fixed exception handling of ksql #81

Codecov Report