bryanyang0528 / ksql-python

A python wrapper for the KSQL REST API.
MIT License
159 stars 67 forks source link

fix: https://github.com/bryanyang0528/ksql-python/issues/98 #99

Closed qtfkwk closed 2 years ago

XHPJ commented 2 years ago

I would actually prefer a

...
else:
       raise InvalidQueryError(rule)
...

or am I missing something 🤔 that way you would still raise the exception in case of a missing semicolon

Ga11u commented 2 years ago

I would actually prefer a

...
else:
       raise InvalidQueryError(rule)
...

or am I missing something 🤔 that way you would still raise the exception in case of a missing semicolon

@XHPJ it should be if rule[-1:] != "": rise InvalidQueryError(rule) This one will cover th case of a missing semicolon and not rise exceptions when there is nothing else to parse.