bryanyee33 / pe

0 stars 0 forks source link

Required to use student id for some commands #12

Open bryanyee33 opened 4 months ago

bryanyee33 commented 4 months ago

For several of the commands such as tag and grade, it is required for the user to type the student id to modify the contact. This is time-consuming and is prone to errors. Eg. Typing A0269501E instead of A0265901E, thus incorrectly modifying the wrong student, possibly without the user realising. This could have been prevented by allowing users to edit via the index such as the delete command.

nus-se-bot commented 4 months ago

Team's Response

Team chose [response.NotInScope]

Reason for disagreement: The devs placed this issue under response.NotInScope, with the reasoning of "In future iterations, we will allow the commands to modify data using indexes.". However, there is no mention of fixing this issue in the UG or DG in the future. Also, there was no explanation on whether rectifying this is less important. Hence, their reasoning is invalid, and there is no justification provided for putting it under response.NotInScope. Moreover, their explanation agrees that this is an issue, and I believe it is a huge feature flaw (explanations below).

image.png


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** The devs have provided no explanation on why this was downgraded, and simply stated "Invalid severity provided.". I believe this severity is justified, as this would affect the majority of users, and could cause major problems for them. Commands that are affected include `grade`, `dgrade`, `tag`, `etag`, `dtag`, showing that this is not limited to 1 or 2 commands. Moreover, `grade` seems to be a core feature of the app seeing as this app is meant for academic instructors, making this a widespread problem. This could lead to incorrectly adding or even modifying the grades of a wrong student without the user realizing it, and they might potentially have to scroll through thousands of students to verify that they are all correct (which is also prone to errors). This could have been easily fixed by allowing these commands to modify by index, where the user could easily verify on the screen the name & details of the student they are modifying. Moreover, indexes are much easier to verify since they are in ascending order, do not contain letters, and contain much less characters as compared to student id.