bryanyee33 / pe

0 stars 0 forks source link

Clear in wrong section of UG #15

Open bryanyee33 opened 7 months ago

bryanyee33 commented 7 months ago

image.png

image.png

Despite the undo command specifying that it can only undo data changing commands, which would refer to the list of commands in section 4.1, it is able to undo the clear command, which is in another section. It should be moved to section 4.1 instead.

nus-se-bot commented 7 months ago

Team's Response

We believe it is a subjective matter. Some commands can overlap different groups.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While I do agree that clear in general could overlap the 2 groups, this is not the case for this, due to the undo command.

Moreover, the devs have completely ignored my main point of this issue, which was that since the UG states the undo command will "revert the changes done by last Data changing command", without a clear indication of exactly which commands can be undone, it is reasonable to assume that a section specifically named "Data Modification Commands" would be what it is referring to.

Since being able to undo a clear command is not expected based on the UG, but in the actual app it is able to do so, this is clearly a bug.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** This is not a mere cosmetic issue, and could cause misunderstandings for the reader. Moreover, the devs did not provide an explanation for this lowering of severity.