search

bryanyee33 / pe

0 stars 0 forks source link

Incorrect composition in UI class diagram #16

Open bryanyee33 opened 3 months ago

bryanyee33 commented 3 months ago

image.png

Based on this diagram, there is composition between MainWindow and UiPart, which is not true since UiPart is abstract.

nus-se-bot commented 3 months ago

Team's Response

Caused by overlapping of dependency lines in PUML.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png

Even if it were caused by PUML, this clearly contradicts the standard notation in the textbook, with a misleading diagram that makes it extremely hard to distinguish which association has this composition, or whether both have this composition. It is up to the devs to make this clearer in the diagram, by possibly adding invisible associations, etc., to make them align properly in the diagram. Moreover, after looking at this issue again, I would like to raise it to severity.Low, as it is not a pure cosmetic bug, and actually hinders the reader. Furthermore, since even such a simple-to-spot error was overlooked by the devs (they can easily see the diagram in real-time while creating it), there is doubt whether this diagram can even be trusted.