Open vanakenm opened 6 years ago
brycebaril
commented
6 years ago Hi @vanakenm! I like the idea! Can you clean this up to not add all the semicolons in? It makes the diff a bit hard to read ;)
I've been slowly adding standard to my packages but I haven't gotten to this one yet. Apologies for no linter here to provide guidance.
vanakenm
commented
6 years ago OK, I can understand that. I've been used prettier more & more, so I only realized the diff afterward. I'll send a cleaned up version.
On Sat, May 26, 2018 at 2:36 AM, Bryce Baril notifications@github.com wrote:
Hi @vanakenm https://github.com/vanakenm! I like the idea! Can you clean this up to not add all the semicolons in? It makes the diff a bit hard to read ;)
I've been slowly adding standard to my packages but I haven't gotten to this one yet. Apologies for no linter here to provide guidance.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brycebaril/node-stats-lite/pull/7#issuecomment-392221016, or mute the thread https://github.com/notifications/unsubscribe-auth/AAynbAywhYu8Qq6rTVUpKyI710NzKKBtks5t2KObgaJpZM4UGE5i .
-- *Martin Van Aken - *Freelance Enthusiast Developer
Mobile : +32 486 899 652
Follow me on Twitter : @martinvanaken http://twitter.com/martinvanaken Call me on Skype : vanakenm Hang out with me : martin@joyouscoding.com Contact me on LinkedIn : http://www.linkedin.com/in/martinvanaken Company website : www.joyouscoding.com
Hi! Found your lib which was exactly what I needed - a small stats package with histogram support. I needed some support to remove outliers, so here is the PR.
I found some mix of "standard" function and fat arrow ones, I used the latter when possible but did not touch the rest. In order to stay in the same convention I did not use let/const.
Just realized I had prettier "on save" - if this is a problem I can easily revert (I just added the methods mentioned, I did not touch anything else).