search

bryceco / GoMap

OpenStreetMap editor for iPhone/iPad
ISC License
321 stars 41 forks source link

Code formatting #535

Closed mormahr closed 3 years ago

mormahr commented 3 years ago

I've just checked out the new swift version and formatting is not according to swift format. (When I run it I have 112/129 changed files). I noticed, for example, mixed tabs / spaces usage. Do you plan to run swiftformat once on everything so it's clean? Otherwise PRs are going to introduce a lot of noise..

You can even add the formatting commit to a ignore-revs file so it can be ignored with git blame.

bryceco commented 3 years ago

I'm not worried about churn at the moment since all the swift files are unconnected to their ObjC origins, so there's no history to lose. You're right that running swift format is a good idea. I'll take a look at the format options today.

bryceco commented 3 years ago

Fixed via 85952f2a451c8a4d89435878e7f0efbb549e46f4