search

bryceco / GoMap

OpenStreetMap editor for iPhone/iPad
ISC License
320 stars 41 forks source link

Use english for values of changeset message-source-placeholder #557

Closed tordans closed 3 years ago

tordans commented 3 years ago

ATM, the placeholder values of the input field for the changeset message source are translated. However, the values I put in there, always be english – eg 'survey' instead of 'Beobachtungen'.

I suggest to always use the english terms for the placeholder.

1C01FDEE-7E85-44AA-9F9A-6632F7EA23A6_1_105_c

PS: I was looking for a way to see the most used source-values, but Taginfo does not show changeset tags according to https://github.com/taginfo/taginfo/issues/305

bryceco commented 3 years ago

What does iD/JOSM do?

bryceco commented 3 years ago

Okay, I did some changeset analysis and I agree they should probably be English. Because these items get translated "automatically" via the normal translation work-flow the only way to enforce "English only" is to mark them as "Do Not Localize" on the translation website, and hope that the translators do the right thing.

bryceco commented 3 years ago

Here are the top source tags, preceded by count. It turns out that there are many non-English entries, but most of them refer to imagery providers. If you want the whole list I can place it somewhere: 7052809 Bing 6207437 survey 1989563 Maxar Premium Imagery 1912338 streetlevel imagery 1726923 streetside 1521981 Maxar Premium Imagery (Beta) 1319044 bing 1172962 Esri World Imagery 1082451 knowledge 1019727 mapillary 817034 local knowledge 620888 openstreetcam 575009 maxar 525441 Mapbox Satellite 523557 aerial imagery 501920 mapillary-signs 410866 esri 407599 Maxar Standard Imagery 356805 Maxar 354845 Esri World Imagery (Clarity) Beta 353160 Bing Aerial Imagery 323835 Strava 323763 tms[22]:https://api.mapbox.com/v4/digitalglobe.2lnp1jee/{z}/{x}/{y}.png?access_token=pk.eyJ1IjoiZGlna... 307907 Mapillary 294138 INEGI:MGN:06-2018 286147 mapbox 276974 DigitalGlobe Premium Imagery 276666 mapillary-map-features 275938 Mapbox 269640 Esri 242698 Bing aerial imagery 237160 JOSM Validator

tordans commented 3 years ago

This sounds like an improvement, yes.

Is it technically possible to hard code the placeholder term? I wonder, if maybe GoMap should just suggest 'survey' as hard coded placeholder term in this case. IMO for the GoMap, 'survey' is the most likely value and users will likely leave it blank otherwise. I only add 'aerial imagery' (probably miss typing it as 'areal images') in cases, where I do couch mapping to refine something in GoMap. It would stille be a free text field, but just suggest one value via the placeholder.

bryceco commented 3 years ago

That's a good idea, since the "etc." should be localized otherwise.