search

bryceco / GoMap

OpenStreetMap editor for iPhone/iPad
ISC License
318 stars 41 forks source link

Problems with some Fields in the Editor #778

Closed Icebird2000 closed 3 months ago

Icebird2000 commented 3 months ago

There is a Problem with the „Description“, „Fix Me“ and the „Note“ fields. image The Format and translation is wrong (should be like the ‚Mapillary Image ID’) and if you swipe from right to left and press delete you cannot edit this fields without leaving the editor. image Here is a sample after deleting a multi line Text.

In the Tags view the fields have a gray box and autofill is active but the previous and next fields are missing. image here are the fields image

bryceco commented 3 months ago

Those fields are special because they allow entering multiple lines of text (UITextView vs UITextField).

If I understand correctly there are 4 different bugs:

  1. Swiping to delete text breaks the control (fixed in ebcd998be920c265870c3c7c4cf6a24758ecee52)
  2. Background color is wrong when using Dark Mode (fixed in eb5938c108225fe09a73afadb6c59200bc4fadc1)
  3. In "All Tags" there is no Next/Previous toolbar (fixed in f75163ae1e80fd6044fdc6a6fc4ccfa48027eccd).
  4. "Unknown" is being displayed in the wrong language

I can't figure out what is happening with the last one. What version of the app is this?

tordans commented 3 months ago

"Unknown" is being displayed in the wrong language I can't figure out what is happening with the last one. What version of the app is this?

image 4.2.4 4204

bryceco commented 3 months ago

Yeah it looks like it's a version that is half-translated.

Icebird2000 commented 3 months ago

Version is 4.2.4 (4204) from the AppStore It happens, if you set the language of the app OS wide (Settings -> Go Map!! -> Language to German) and change the language in Go Map!! under Settings to English. I thing, this is sometimes common on other devices because you want the english tag names.

dieterdreist commented 3 months ago

Yesterday I encountered a check_date and opening_hours:check_date (or the other way round), and both had a plus-button, but while the check_date plus button updated the date, the other button opened the camera

sent from a phone

On 3 Jul 2024, at 09:12, Icebird2000 @.***> wrote:

 Version is 4.2.4 (4204) from the AppStore It happens, if you set the language of the app OS wide (Settings -> Go Map!! -> Language to German) and change the language in Go Map!! under Settings to English. I thing, this is sometimes common on other devices because you want the english tag names.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

Icebird2000 commented 3 months ago

Yesterday I encountered a check_date and opening_hours:check_date (or the other way round), and both had a plus-button, but while the check_date plus button updated the date, the other button opened the camera sent from a phone

Yes, i think this is by design. The plus-button on the opening_hours tag opens always the camera.

Icebird2000 commented 3 months ago

By the way, the key should be check_date:opening_hours Wikientry - check_date If you use this key, everything is working correct.

bryceco commented 3 months ago

It happens, if you set the language of the app OS wide (Settings -> Go Map!! -> Language to German) and change the language in Go Map!! under Settings to English.

Okay that makes sense. The translation for “Unknown” for those fields isn’t coming from the presets, but I can change it so it does.

bryceco commented 3 months ago

opening_hours:check_date

Nice, we just need to do the test for check_date before anything else (e.g. website:check_date).

dieterdreist commented 3 months ago

no, the object is this and the tag was check_date:opening_hours

https://www.openstreetmap.org/way/30698972

sent from a phone

On 3 Jul 2024, at 14:35, Icebird2000 @.***> wrote:

 By the way, the key should be check_date:opening_hours Wikientry - check_date If you use this key, everything is working correct.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.

Icebird2000 commented 3 months ago

I don’t know if I should open a new case, but i found another field error. Possible with dark mode. If i change the „No - Yes“ Button to no or yes the text in the field is not shown. If i click in the field it appears.

image

image

bryceco commented 3 months ago

the tag was check_date:opening_hours

Turns out we weren't looking for any variants of check_date:*, so I've updated it to do that.

bryceco commented 3 months ago

If i change the „No - Yes“ Button to no or yes the text in the field is not shown. If i click in the field it appears.

That's by design. We support displaying or typing in a custom value so we have to show the text when you click the text field. See https://taginfo.openstreetmap.org/keys/backrest#values for examples of edge cases.

bryceco commented 3 months ago

Closing this, please open a new ticket for new bugs :)