Disable dark-mode basemap

[upintheairsheep]

Hello, can you add an option to disable the altered dark mode base maps, for example Mapnik? It may be helpful for some users, but the low-quality dithering makes it unfavorable for others.

[bryceco]

What do you mean by low-quality dithering? It shouldn't be changing the resolution.

[upintheairsheep]

What do you mean by low-quality dithering? It shouldn't be changing the resolution. Not dithering, but it just looks a bit unclean compared to normal Mapnik/etc.

[bryceco]

Long-time commentators know I don't like configuration options, so if the brightness level is inappropriate we should fix it, rather than provide an option to disable it.

I don't use DarkMode myself so I'd prefer the community decide on a level of dimming that is agreeable to everyone. Currently it is set at -40% (or 60%) brightness. There are various online tools that will show you what other brightness levels look like (you can upload screenshots). Could you post examples of what you like and we can get comments from other users?

[bryceco]

https://github.com/bryceco/GoMap/issues/789

[verhovsky]

It's not the amount of brightness, but that whatever you're doing to invert the colors is making text look bad, probably because it affects the blurriness around letters ("dithering") somehow, though admittedly it's already bad because open street map renders the map at half resolution to save money and looks terribly blurry on modern high pixel density displays.

[bryceco]

It's using a CoreImage filter that adjusts the brightness and nothing else, but that exposes the graininess of the underlying image.

https://github.com/bryceco/GoMap/blob/d49d910a52ae379986ebdaaa3a131c29ad8f8e30/src/Shared/Utility/DarkModeImage.swift#L22

[bryceco]

I've reduced the change in brightness. Hopefully that is sufficient.