search

bryceco / nethack-cocoa

OS X tile port of NetHack-3.6 using the native Cocoa framework
11 stars 4 forks source link

Use system colours for text background #29

Closed lightbulbjim closed 2 years ago

lightbulbjim commented 3 years ago

Ok, I had a go at fixing the dark mode problem mentioned in #28.

The character creation screen, the message log, and tooltips now use standard system colours for their backgrounds, so will switch colour when the system light/dark mode changes.

I also changed the blue text from NSColor.blueColor (hard to read against a dark background) to NSColor.systemBlueColor. The new blue looks like this:

Screenshot 2021-08-11 at 16 12 44 Screenshot 2021-08-11 at 16 12 59

I haven't touched the ASCII colour palette.

Give it a try and see what you think. Let me know if I missed anything.

bryceco commented 2 years ago

Huge apology for being so late acknowledging this! In fact it is quite by accident that I noticed a reference to the issue while looking through old Reddit posts, but for some reason I never received or noticed a notification from GitHub. I'm going to merge this and push out a new release to the app store as soon as I'm back from traveling (which will be a few more weeks).

Again apologies, and thank you for the pull request!