search

bryceosterhaus / metal-to-react

Codemods for migrating metal-jsx to react
13 stars 2 forks source link

.value() is sometimes left on the end of PropTypes for externally declared PropTypes #2

Open erickakoyama opened 5 years ago

erickakoyama commented 5 years ago

I'm not sure if this is worth adding a check for, but there were two cases where after conversion our prop declaration went from something like:

truncated: Config.bool().value(false)

to

truncated: PropTypes.bool.value(false)

These were both somewhat exceptional cases. Both instances were that we had defined a reusable prop shape outside of the actual component class. What do you think?

bryceosterhaus commented 5 years ago

How many instances of this do you think occur for you? I'd probably say if its less than 5 or 10, just manually update those for now. If its more than that, I can update the transform.