search

brycx / pasetors

PASETOrs: PASETO tokens in pure Rust
MIT License
91 stars 10 forks source link

`time` crate is broken for rust 1.80.0 at version 0.3.30 #129

Closed shadogar closed 1 month ago

shadogar commented 1 month ago

https://github.com/time-rs/time/issues/693

The fix is to update the crate version.

shadogar commented 1 month ago

Currently consumers of this crate using rust 1.80.0 are unable to compile due to this issue

brycx commented 1 month ago

Hi @shadogar,

Thanks for bringing a potential issue to my attention.

I just built and ran the tests in release mode locally for 1.80.0 and re-ran the daily tests in CI, that also run latest Rust on stable and nightly channels. Both compiled fine.

The Cargo.toml doesn't specify the SemVer patch version, so time should automatically be the newest & compatible version available at compile-time. This is what my build logs show both locally and in CI.

Try a cargo update, which should solve this. Or perhaps you meant for this to be more of a PSA-like issue (otherwise, I'll close this issue for now as this problem is not fixable in pasetors)?

shadogar commented 1 month ago

Hi @shadogar,

Thanks for bringing a potential issue to my attention.

I just built and ran the tests in release mode locally for 1.80.0 and re-ran the daily tests in CI, that also run latest Rust on stable and nightly channels. Both compiled fine.

The Cargo.toml doesn't specify the SemVer patch version, so time should automatically be the newest & compatible version available at compile-time. This is what my build logs show both locally and in CI.

Try a cargo update, which should solve this. Or perhaps you meant for this to be more of a PSA-like issue (otherwise, I'll close this issue for now as this problem is not fixable in pasetors)?

Indeed running cargo update did fix the issue. Thank you! I'll close the issue.