search

brylie / pym-registration-2013

Registration form calculator for Pacific Yearly Meeting 2013.
0 stars 1 forks source link

Deposit % validator - enhancement #22

Open ddbean opened 11 years ago

ddbean commented 11 years ago

We need a new validator added to the script. If someone puts less than 100% deposit, then they do not get the 5% discount. Can something pop up to remind them of this fact when less than 100% is entered?

ddbean commented 11 years ago

I've added a 4th option to Early/Full/Late fees that says N/A (Early But Less 100% Deposit), so now just need to remove the block to allow manual selection of new item, which will use the full price variable if selected.

brylie commented 11 years ago

I can remove the readonly attribute from the radio box, but I don't think this is ideal. We are overworking that form element.

I think that a simpler solution would be to move the discount field lower in the form,to be directly above the total fees due field (below stipend). Then, based on the user input in the amount enclosed field, the discount will contain either 5% or zero.

Changes will update in real time, so that the user gets feedback when their deposit choice drops below 100%. We will also need to make sure that descriptive text is concise, as well as directly related to this field.

ddbean commented 11 years ago

I guess you missed my earlier email that said I found the code to make the radio selection and Earlier Discount field user-editable, which I changed and up-loaded to server. I couldn't tell people they don't get the early discount if less than 100% deposit and not give them an option to adjust the form. It's been like this for a few days now and people haven't been complaining, BUT no one has used the manual over-ride yet either, so I'm not 100% sure. 

I'm not understanding the impact of "overworking" the form elements, so I'll defer to your experience and best solution to use. I've tested it and it does update the fees correctly when manual override is done.

Review the changes I've done on the form (including the new text explaining the manual over-ride) and let me know which way you wish me to proceed. In Peace Don Bean ddbean@me.com

On May 01, 2013, at 04:54 PM, Brylie Oxley notifications@github.com wrote:

I can remove the readonly attribute from the radio box, but I don't think this is ideal. We are overworking that form element. I think that a simpler solution would be to move the discount field lower in the form,to be directly above the total fees due field (below stipend). Then, based on the user input in the amount enclosed field, the discount will contain either 5% or zero. Changes will update in real time, so that the user gets feedback when their deposit choice drops below 100%. We will also need to make sure that descriptive text is concise, as well as directly related to this field. — Reply to this email directly or view it on GitHub.