search

brynary / rack-bug

Debugging toolbar for Rack applications implemented as middleware
MIT License
1.08k stars 104 forks source link

Rails 3.1 compatibility - Encoding::CompatibilityError - Is this project still maintained? #36

Open fabn opened 13 years ago

fabn commented 13 years ago

I used this a long time ago when still using Rails 2.3.x, and I liked it very much. Now I'd like to use it on my new Rails 3.1 project, but I see no updates, it's more than one year that Rails 3.0 is out and the master branch still points to 2.3.x version.

I've tried it (rails3 branch) in a 3.1 (with Ruby 1.9.2) project and I get this error: 

Encoding::CompatibilityError (incompatible character encodings: UTF-8 and US-ASCII):

I saw that is the same error of #7 which is still pending.

Is there any chance that this project will be updated to support recent versions of Rails?

knzai commented 13 years ago

I had grand plans to update eveythig after getting commit, but got super busy. If you make a fresh fork off of master and send pull requests, I'll merge them in. Branch per feature/set of changes, and with tests, preferably, but at this point it'd be nice to even see it running on 3x

knzai commented 13 years ago

There is a pull request that needs a little tweaking, that I'll gladly merge in. As I mentioned, feel free to submit pull requests and I'll merge them.

pboling commented 12 years ago

I am also running into this error in my fork, rack-insight. Looking into a fix.

pboling commented 12 years ago

For me I was able to fix it by copying the fix that was applied to Rack::Bug awhile ago:

https://github.com/pboling/rack-insight/commit/e1b7b3b7337a88053c478a8b50ddbf0f380fe936