bryntum / support

An issues-only repository for the Bryntum project management component suite which includes powerful Grid, Scheduler, Calendar, Kanban Task Board and Gantt chart components all built in pure JS / CSS / TypeScript
https://www.bryntum.com
53 stars 6 forks source link

Editor does not open on single click for assigned resources column with `triggerEvent : 'cellclick'` #9981

Closed ghulamghousdev closed 22 hours ago

ghulamghousdev commented 3 weeks ago

Forum post

Hello, We configured the Gantt to be single click edit, this was working fine in v5 of the Gantt but since moving to V6, single click worked in other cells but not the Assigned Resource field. With the code added to use cell click edit, the Assigned Resource cell was not clickable at all. This has been repro'd on your demos adding in the following code:

cellEdit : {
triggerEvent : 'cellclick'
},

https://github.com/user-attachments/assets/a1f1c259-2a5c-4056-889a-7744857819d0

Is this a known issue? Paul

pwmather commented 3 weeks ago

Thank you for raising, hopefully this can be patched quickly @ghulamghousdev

ghulamghousdev commented 3 weeks ago

The reason for this is: ResourceAssignmentColumn has its own onCellClick and we do not check for cellEdit.triggerEvent.

The editor opening is vetoed here:

    async onCellClick({ cellSelector, target, event, column }) {
        if (column.onCellClick) {
            // Columns may provide their own handling of cell editing
            return;
        }
pwmather commented 3 weeks ago

Thanks @ghulamghousdev - we'll take a look at that

pwmather commented 3 weeks ago

Was this an undocumented change in v6 @ghulamghousdev as it worked fine before when we were on v5.

ghulamghousdev commented 3 weeks ago

@pwmather this is a regression and not something intentional that is why no docs exist for it. We will fix it soon. Hopefully it will be part of the next patch release.