Hey there! Thank you for wanting to improve Resurrection. After reviewing your changes, I have decided not to merge them in for the following reasons:
All files inside the /data directory of this repository are not referenced in the compiled Jars; Resurrection does not use or reference these files when writing files in production. This means that any changes to the files in this directory are purely for documentation purposes and provide no real use to the final Jar. However, if the documentation is wrong, I am more than happy to merge it in. Unfortunately they are not, which brings me to my next topic.
The documentation changes you made do not represent the file that Resurrection writes upon being enabled. The value for resurrection_time being 120 implies that players will respawn 120 milliseconds after their death, not minutes (which is where I think your confusion lies). The default value, 86400000 milliseconds, is the correct value since this correctly translates to 24 hours, the default resurrection time.
Unless you see something that I'm somehow not aware of, especially since I released Resurrection Version 1.3.1 yesterday, I will be closing this for invalid changes. If you make more changes in your fork, feel free to make another PR!
Hey there! Thank you for wanting to improve Resurrection. After reviewing your changes, I have decided not to merge them in for the following reasons:
/datadirectory of this repository are not referenced in the compiled Jars; Resurrection does not use or reference these files when writing files in production. This means that any changes to the files in this directory are purely for documentation purposes and provide no real use to the final Jar. However, if the documentation is wrong, I am more than happy to merge it in. Unfortunately they are not, which brings me to my next topic.resurrection_timebeing 120 implies that players will respawn 120 milliseconds after their death, not minutes (which is where I think your confusion lies). The default value, 86400000 milliseconds, is the correct value since this correctly translates to 24 hours, the default resurrection time.Unless you see something that I'm somehow not aware of, especially since I released Resurrection Version 1.3.1 yesterday, I will be closing this for invalid changes. If you make more changes in your fork, feel free to make another PR!