search

brysontyrrell / ODST

The Open Distribution Server (ODS) is an open-source package distribution and syncing solution for IT administrators to serve as a potential alternative for the Jamf Distribution Server.
38 stars 5 forks source link

Update socket-timeout #8

Open MScottBlake opened 7 years ago

MScottBlake commented 7 years ago

This change increases the default socket timeout from 60 seconds to 90 seconds to better handle large file uploads.

brysontyrrell commented 7 years ago

In an ideal deployment, you would be uploaded to an ODS on your local network and it would initiate a sync to the other ODS instances. In those cases, you would be able to upload at high speeds and a 90 second timeout would be just fine.

But for the cases where the ODS is not on the same network, a very large upload would likely take more than 90 seconds. It might be more prudent to increase the timeout to 300 seconds (5 minutes).

MScottBlake commented 7 years ago

In my testing (admittedly, it's a local server), the 90 second timeout will only trigger if it has been 90 seconds since an upload chunk has been sent. The total upload can and will work when it takes longer than 90 seconds to process.

You may still be right that 90 seconds is too short, but I'm skeptical about 5 full minutes. I don't know if it will hurt performance to leave the socket open longer than necessary when the server is put under load, but 300 seconds also works in my localized testing.

[Edited for clarity]