Globals, Swagger, and CI/CD Support

brysontyrrell / Possum

A packaging tool for Python based AWS serverless applications.

MIT License

21 stars 2 forks source link

Globals, Swagger, and CI/CD Support #10

Closed tomislacker closed 6 years ago

tomislacker commented 6 years ago

Globals Support

Function runtimes can now be gleaned from the SAM-exclusive Globals section. Example:

Globals:
  Function:
    Runtime: python3.6

Swagger

Possum will now be able to ship swagger files whereas previously, possum and aws cloudformation package were not compatible. Meaning that a local swagger file such as the following was not supported:

Resources:
  ApiGateway:
    Type: AWS::Serverless::Api
    Properties:
      DefinitionUri: swagger-dist.yml
      StageName: !Ref StageName

CI/CD

In many CI/CD environments, there aren't named profiles for AWS credentials but instead environment variables injected into the execution environment. Possum now supports copying the AWS credential variables into the docker environment when invoked with --docker.

Closes #1 Closes #7 Closes #8

tomislacker commented 6 years ago

@brysontyrrell sorry for the fresh push today, I had missed pushing a fixup last week.

After discussing the workflows with some colleagues, I also filed #12 to see what your thoughts were on that. I think that's the direction we're going to go but I was hoping to get your blessing on it so that it'd still be something we could merge back in instead of strictly forking.

brysontyrrell commented 6 years ago

@tomislacker These changes all look good to me. I'll merge this and update PyPI later today.

brysontyrrell commented 6 years ago

@tomislacker Can you update the README with the new improvements and the swagger file feature?

tomislacker commented 6 years ago

@brysontyrrell My apologies, I even made myself a reminder to do that and then ignored it. Give me a few minutes and I'll have a rebase pushed up.

tomislacker commented 6 years ago

@brysontyrrell Actually, I had taken a look and realized I wasn't sure what really needed updating. What specifically would you like me to note?

The globals feature is something that is probably expected by most and I don't think it needs noting (but if you'd like it, I will)
The swagger feature is also something I think most would expect, though maybe I could note how possum is otherwise incompatible with aws cloudformation package?
The CI/CD feature of using inherited environmental variables when using --docker is something already described under the AWS Credentials header. And using possum without docker should not be affected.

Just let me know what you'd like to see and I'll make it so.

tomislacker commented 6 years ago

Thank you! I hope my thoughts on the README didn't come across to direct because that wasn't my intent. I was mostly asking for clarification on what you might want to see in it.

brysontyrrell commented 6 years ago

v1.4 is now available on PyPI: https://pypi.org/project/possum/