brytebee / AwesomeBooks

In this project, I built a simple website that allows users to add/remove books from a library list of books. I used JavaScript objects and arrays. I also used vanilla JavaScript DOM manipulation to simulate REACT and AJAX's single-page website concept. Lastly, I used is HTML and CSS3 technologies.
https://brytebee.github.io/AwesomeBooks/
7 stars 1 forks source link

Peer Code Review #4

Closed mmatongo closed 3 years ago

mmatongo commented 3 years ago

Hello @brytebee, we absolutely love the work you've done here and can't wait to see what the finished product looks like.

However we have a few suggestions on how you can make your website better. Note that these are only suggestion's.

1.

To keep your code as clean as possible we recommend putting this line of code; https://github.com/brytebee/AwesomeBooks/blob/e74c7eb1aadcca31cf2095a915e8d974faa0b08e/index.html#L18 In the head section of your website and adding defer to it, this will make it so you don't need to have all your script files at the end of the page. e.i

<script defer src="script.js"></script>

2.

We also noticed that currently there is no live demo of your web app, we'd really love to see what it looks like without having to clone the repo as well as follow active changes without cloning every sing time; You can read more about deploying a page using GitHub Pages here.

3.

Consider separating the artifacts in your repository based on what they are. e.i placing the js files within a js folder to keep your repository organised, the same applies for the css files.