search

bryx-inc / BRYXBanner

A lightweight dropdown notification for iOS 7+, in Swift.
MIT License
1.01k stars 143 forks source link

Change MinimumOSVersion to 8.0 to support Carthage builds #81

Closed aalenliang closed 5 years ago

aalenliang commented 7 years ago

At the moment Carthage can build BRYXBanner for iOS but since it targets iOS 7, the resulting application cannot be submitted to iTunes Connect.

https://github.com/Alamofire/Alamofire/issues/352

harlanhaskins commented 7 years ago

I agree with this. No real need to still support 7; if someone wants to submit this with 7 they can just copy the older file.

If you want to make this change in a PR, I'd appreciate it!

aalenliang commented 7 years ago

Wow, Thanks for the quick reply. I'll make the change soon.