search

bryzgaloff / airflow-clickhouse-plugin

The most popular ClickHouse plugin for Airflow. 🔝 Top-1% downloads on PyPI: https://pypi.org/project/airflow-clickhouse-plugin! Based on mymarilyn/clickhouse-driver.
MIT License
144 stars 36 forks source link

Update clickhouse.py #85

Closed amolsr closed 5 months ago

amolsr commented 5 months ago

Added get_pandas_df method.

bryzgaloff commented 5 months ago

Hi @amolsr and thank you for a proposal. get_pandas_df is not required as a core functionality for the plugin, so I may not accept this contribution. Such a feature must be introduced as a separate mixin which can be also wrapped into a separate Airflow plugin and be reusable with other plugins too. It must not be coded into ClickHouse plugin itself since it is not a CH-specific functionality.