Closed shripathee closed 8 years ago
I'll take a look later tonight. Tied up with client work at the moment!
Okay :)
Everything is working with Ember CLI 1.13.13 and Ember 2.3.0-beta.3. So it's definitely an issue with the beta version of the CLI. Maybe something with the loader. I'll keep you posted.
Ok, so the problem is because the new loader.js
defines a variable called global
, which overrides NW's own global
. Joy!
// loader.js
var global = this;
(function() {
// ...
loader = {
noConflict: function(aliases) {
var oldName, newName;
for (oldName in aliases) {
if (aliases.hasOwnProperty(oldName)) {
if (oldGlobals.hasOwnProperty(oldName)) {
newName = aliases[oldName];
global[newName] = global[oldName];
global[oldName] = oldGlobals[oldName];
}
}
}
}
};
I'm guessing we can rename global
to _this
or something that doesn't conflict in loader.js
, but I'm not 100% sure. That's just from quickly looking over the file.
Great job tracking this down!
loader.js@3.6.1 is released with your fix...
w00t!
Updated loader.js to 3.6.1. nw is working now. Thanks guys :)
Getting these errors:
Ember CLI version: 2.2.0-beta.3 Ember version: 2.3.0-beta.3