Using getImageData with the willReadFrequently attribute

bs-community / skinview3d

Three.js powered Minecraft skin viewer.

https://skinview3d-demo.vercel.app

MIT License

550 stars 90 forks source link

Using getImageData with the willReadFrequently attribute #125

Closed Hacksore closed 1 year ago

Hacksore commented 2 years ago

Should we consider allowing the use of willReadFrequently to suppress this warning?

process.js:30 Canvas2D: Multiple readback operations using getImageData are faster with the willReadFrequently attribute set to true. See: https://html.spec.whatwg.org/multipage/canvas.html#concept-canvas-will-read-frequently

bribes commented 2 years ago

Seems good!

samzhangjy commented 1 year ago

Any updates on this? I'm currently building a project that includes many SkinViewer instances and the warning is really annoying.

Hacksore commented 1 year ago

@yushijinhun Could you please have a look at the referenced PR?

Hacksore commented 1 year ago

I've opened a PR in the upstream utils repo https://github.com/bs-community/skinview-utils/pull/16. Once we get that merged we can move forward with a fix here.

Hacksore commented 1 year ago

Once @yushijinhun publishes a new version we can bump the utils package to close this out.