search

bs-community / skinview3d

Three.js powered Minecraft skin viewer.
https://skinview3d-demo.vercel.app
MIT License
540 stars 90 forks source link

Show only heads with skinview3d #161

Closed DarthGigi closed 8 months ago

DarthGigi commented 9 months ago

Is it possible to tell skinview3d to show only the head and not the full body? I currently use headview3d but would rather use skinview3d as headview3d isn't being updated. If not, could support for this be added?

Hacksore commented 9 months ago

This is possible with some disabling of certain parts, it's not perfect but it works.

https://codesandbox.io/p/sandbox/skinview3d-head-only-2nmhvt

Maybe @SMCodesP can raise a PR to add this functionally here 🙏.

SMCodesP commented 9 months ago

Hi @Hacksore,

Thank you for mentioning me! I appreciate it. I'll do my best to create a pull request with the functionalities that headview3d offers. I initially created it for a personal project that I abandoned some time ago, but I'll try to provide support for the latest commits and maybe submit a pull request that directly implements an option for headview only.

DarthGigi commented 9 months ago

Hey @SMCodesP,

I hope you're doing great. I was wondering if there has been any progress on this issue?

SMCodesP commented 9 months ago

Hello @DarthGigi, I was analyzing the old code of my fork, as it is very outdated as you said, there were many merge errors, so initially I tried to reimplement the code already in the main code and add the option to just render the head, but this would possibly take some time to analyze and try for personal time reasons, so I will just update the code of the old library and, over time, I will send a PR for the main code to implement it as an option.

SMCodesP commented 8 months ago

@DarthGigi

Hello, how are you? I've updated the code to the latest version of Skinview3d. This time, I didn't implement it directly into the original code. Instead, I removed functionalities that are not related to rendering the character's head. Therefore, my fork currently doesn't aim to make a pull request for obvious reasons that it would harm the source code. For now, I don't have much time to implement an option in the original code to simply render the head. However, perhaps soon I'll make some contribution to the source code through a pull request. Below are the links to the template on CodeSandbox, the fork, and the npm link:

Template on CodeSandbox: https://codesandbox.io/p/sandbox/headview3d-template-9ck47g Fork link: https://github.com/SMCodesP/headview3d NPM link: https://www.npmjs.com/package/headview3d

DarthGigi commented 8 months ago

@DarthGigi

Hello, how are you? I've updated the code to the latest version of Skinview3d. This time, I didn't implement it directly into the original code. Instead, I removed functionalities that are not related to rendering the character's head. Therefore, my fork currently doesn't aim to make a pull request for obvious reasons that it would harm the source code. For now, I don't have much time to implement an option in the original code to simply render the head. However, perhaps soon I'll make some contribution to the source code through a pull request. Below are the links to the template on CodeSandbox, the fork, and the npm link:

Template on CodeSandbox: codesandbox.io/p/sandbox/headview3d-template-9ck47g Fork link: SMCodesP/headview3d NPM link: npmjs.com/package/headview3d

Thank you so much @SMCodesP! I really appreciate it!

Hacksore commented 8 months ago

Thanks @SMCodesP! Going to close this for now.