search

bsaffel / benchmarker

macro trainer | build optimizer | practice tool
10 stars 0 forks source link

Build order unit type considered 2x instead of properly being evaluated as 2 separate units #191

Closed bsaffel closed 9 years ago

bsaffel commented 10 years ago

There is an odd edge case bug during build order evaluation where if two of the same unit are back to back, but in the followup build you build them within 15 seconds of each other, only the first step is completed, and then the second unit just increments the number, it does not actually complete the second step

bsaffel commented 9 years ago

A fix could simply be to add a check to see if the previous step is satisfied AND the current step contains the same unit type. If so, do not increment previous step, simply evaluate against the current step.

bsaffel commented 9 years ago

Here is an example of this in action. screenshot2014-10-23 00_25_29 screenshot2014-10-23 00_25_35 screenshot2014-10-23 00_26_24

bsaffel commented 9 years ago

There also may be a bug here. That timer really shouldn't be evaluating at all if the unit was checked against the previous step.

bsaffel commented 9 years ago

This is actually because the previous step is being evaluated again even though it is complete, but the next step appears to be the one that is failing because that is what the cursors were on as the previous step is being evaluated.