search

bsaffel / benchmarker

macro trainer | build optimizer | practice tool
10 stars 0 forks source link

Timer expired failed a step incorrectly #232

Closed bsaffel closed 9 years ago

bsaffel commented 10 years ago

The multi unit timer expired incorrectly on a step that did not have multiple units and where no single unit had been created for that step yet. This did occur two steps after a 2x Extractor step however, so that could be the offending step causing the timer not to be stopped appropriately on completion.

screenshot2014-07-08 11_41_12

bsaffel commented 10 years ago

Enhanced the reset logic for that timer when a step is completed correctly. I believe that this may be fixed now

bsaffel commented 10 years ago

Apparently someone else ran across this also. Thanks NeoBlade for reporting the issue.

screenshot2014-07-21 19_16_12

bsaffel commented 10 years ago

It appears as though this only happens after an Overlord is created. It somehow triggers the multi-unit failure timer when it should not.

bsaffel commented 10 years ago

Here is an example of a time when the multi unit failure timer was triggered incorrectly.

screenshot2014-09-05 17_38_26

bsaffel commented 9 years ago

The latest refactorings should have definitely eliminated this problem.