bsalha1 / Printer

This is a plugin for Minecraft that aids in building, as it gives the player creative mode and charges them for each block they place. All exploits are patched as well.
GNU General Public License v3.0
6 stars 5 forks source link

[Suggestion] Add support for Lands #6

Open larssieboy18 opened 3 years ago

larssieboy18 commented 3 years ago

Hi there,

Plugin looks really good! I was wondering if there could be support added for Lands? They have a developer API, so it should be possible I think? It would be great if you could toggle in the config if people are allowed to "print" in the wilderness or just in their own land.

If you need a tester, let me know!

bsalha1 commented 3 years ago

Sure I will work on that this week.

bsalha1 commented 3 years ago

Could you test this out: https://www.mediafire.com/file/luymh94hgrrmewo/Printer-LATEST.jar/file Just make sure to go into the config.yml and turn lands.support: true and if you could make sure all the other lands configs work. Thanks!

larssieboy18 commented 3 years ago

Hi, thanks for the quick implementation! I tested it and it does disallow blocks to be placed inside other lands. However, when you place a block in a land claimed by someone else, it still charges you, which is really not ideal.

The fact that people shouldn't be able to place blocks in the wilderness does not seem to work tho.

It only shows error messages that Lands sends out, so I do not know for sure if the plugin actually blocks placing in other lands/wilderness properly or that it is because Lands blocks it by itself.

bsalha1 commented 3 years ago

Thanks for testing. I made it so it doesn't charge the player when they place in a disallowed territory. Also I believe I have fixed the wilderness issue now. It's basically shots in the dark until I figure out what counts as a wilderness on the API - if you could test this that would be great: https://www.mediafire.com/file/luymh94hgrrmewo/Printer-LATEST.jar/file thanks.

bsalha1 commented 3 years ago

Also delete your printer config.yml and do /printer reload before testing, as I made a pretty big change

larssieboy18 commented 3 years ago

I tested it and it indeed blocks it now when you try to build inside someone else's land and/or the wilderness. It also doesn't charged for blocks when you are not allowed to place them.

However, I am also not allowed to place blocks in my own land, so that is not how it is supposed to be xD

bsalha1 commented 3 years ago

Haha yeah that's not good, I will see if I can found out why that is, thanks again for testing

bsalha1 commented 3 years ago

https://www.mediafire.com/file/luymh94hgrrmewo/Printer-LATEST.jar/file okay this should work for testing if a person is in their own land so they can place in their own land.

larssieboy18 commented 3 years ago

Sorry for my absence, we're in the middle of moving servers to a different host and not everything is going smoothly xD Will update you on whether it works or not!