search

bsansouci / bsb-native

Build system for OCaml/Reason
Other
245 stars 10 forks source link

Add some exceptions for bsb-native #16

Closed jaredly closed 6 years ago

jaredly commented 6 years ago

lol there's so much trailing whitespace in these files

Test Plan: make worldnative

bsansouci commented 6 years ago

Hey @jaredly Thanks for contributing! This is awesome. I just grepped failwith and saw a couple more inside bsb_config_parse.ml (I think for a lot of those you can use Bsb_exception.config_error. There's also bsb_helper_packer and bsb_helper_linker.

The rest looks good!

bsansouci commented 6 years ago

Oh and before I merge could you run make force-snapshotml so we get the packed files updated?

jaredly commented 6 years ago

Ok, I'll do the rest in a separate PR. Just wanted to get this in to make sure I was doing it right

bsansouci commented 6 years ago

Thanks a lot! This is great :)