search

bsatrom / Knockout.Unobtrusive

Unobtrusive View to ViewModel bindings for KnockoutJS
http://bsatrom.github.com/Knockout.Unobtrusive/
44 stars 1 forks source link

Test 'Pascal-cased fields, with name instead of id set' shouldn't pass #3

Closed aaronpowell closed 13 years ago

aaronpowell commented 13 years ago

IE mistakenly implements the getElementsByName by making it case insensitive, according to the W3C spec it shouldn't be (http://www.w3.org/TR/DOM-Level-2-HTML/html.html#ID-71555259) so in its current state this test wont pass in all browsers.

I'd recommend that either the test is removed or its changed so that the underlying logic will attempt some smarter logic (transform the value to have the first letter uppercase)

bsatrom commented 13 years ago

Great catch! :/ Need to remember to keep running these tests in Chrome and IE on a regular basis

aaronpowell commented 13 years ago

I've created a Cakefile with a file system watcher in my fork so it'll do an automatic compile to JS. I've also tried to get the tests running under nodejs but I'm not having much luck :(

bsatrom commented 13 years ago

That will be nice. Been taking the lazy route and just running -cw so far. :)

Are you running node on Windows via Cygwin, or on a Mac? Haven't tried doing a test setup via node yet...

-----Original Message----- From: aaronpowell [mailto:reply@reply.github.com] Sent: Monday, August 15, 2011 6:31 AM To: Brandon Satrom Subject: Re: [Knockout.Unobtrusive] Test 'Pascal-cased fields, with name instead of id set' shouldn't pass (#3)

I've created a Cakefile with a file system watcher in my fork so it'll do an automatic compile to JS. I've also tried to get the tests running under nodejs but I'm not having much luck :(

Reply to this email directly or view it on GitHub: https://github.com/bsatrom/Knockout.Unobtrusive/issues/3#issuecomment-1806399

aaronpowell commented 13 years ago

Cygwin is what I run for the majority (I do have a linux VM but booting it is a pain).

I've done a test setup in Postman (https://github.com/aaronpowell/postman). Once it's sorted it's sweet.

bsatrom commented 13 years ago

once again, great catch. I actually was already doing the transformation you mention above for ID's, but didn't for name properties b/c I overlooked the passing test in IE. in any case, it's fixed now.