Categories - Githubissues

bsc-networks / workshift-website

A new workshift website, created by students of CS169

MIT License

3 stars 0 forks source link

Categories #16

Closed ECIson closed 9 years ago

ECIson commented 9 years ago

I made some UI changes to the navbar and workshift edit page in order to display and modify categories. You can add workshifts to categories and remove from them in their edit page (so there is some basic functionality). When a category is deleted the workshift is not deleted, btw (and by default its category name is Uncategorized) I am somewhat of a novice at these kind of things so any suggestions will be helpful.

jgraycar commented 9 years ago

Hey @ECIson! Nice job on this :smiley: a few small things:

In the show method of categories_controller, I think you meant to have it respond_with(@category)
In categories_controller, can you make the set_category method private?
In the category_name method of the workshift model, you can condense the first three lines into return category.name unless category.nil?

Other than that, it looks awesome! Great work :+1: