search

bsc-networks / workshift-website

A new workshift website, created by students of CS169
MIT License
3 stars 0 forks source link

Check verifier's password when checkoff #57

Closed julienfortin closed 9 years ago

julienfortin commented 9 years ago

Make sure that the password of the verifier is checked when checkoff.

julienfortin commented 9 years ago

Done, I am about to commit the code

mitar commented 9 years ago

Hm, what exactly is this? Is this that even if you are signed in, you have to still enter the password? Like it is in the current workshift website?

I think this is not a good UX. Imagine that on the mobile device you have to enter your password every time you want to sign off.

What I would do is instead have this be a simple sign-off as it was before, and then have a special "quick sign-off" page where user does not have to be logged in at all to sign off people. So then we would have that page open in the kitchen. That one takes username, password, and who to sign off and this is it.

But if you log in into the system, then you are in and you do not have to reenter passwords again.

What do you think?

(I am reopening this to discuss.)

julienfortin commented 9 years ago

I think that the title plus the description are pretty accurate to explain the issue. On the original version you could checkoff workshift without asking a verifier (without using the verifier password to confirm the checkoff).

Now only the verifier (not the work shifter) has to enter his password.

Making a sign off page is a new issue, it's even a "feature" since it wasn't design this way on this workshift website.

I hope this make sense

julienfortin commented 9 years ago

The discussion should continue there: https://github.com/bsc-networks/workshift-website/issues/66