search

bsc-performance-tools / extrae

Instrumentation framework to generate execution traces of the most used parallel runtimes.
https://tools.bsc.es/extrae
GNU Lesser General Public License v2.1
62 stars 38 forks source link

errors in test scripts #20

Closed loveshack closed 4 years ago

loveshack commented 6 years ago

When trying to get make check working, I noticed that some test scripts use $(...) rather than ${...}. There's a patch at https://copr-dist-git.fedorainfracloud.org/cgit/loveshack/livhpc/extrae.git/plain/extrae-tests.patch?h=epel7 reproduced below. (I haven't yet tested the current version of the RPM packaging it's from, in case you're interested in that.)

diff -rN -u old/tests/functional/launcher/test-binary-rewrite.sh new/tests/functional/launcher/test-binary-rewrite.sh
--- old/tests/functional/launcher/test-binary-rewrite.sh    2018-09-24 21:07:18.350597378 +0100
+++ new/tests/functional/launcher/test-binary-rewrite.sh    2018-09-24 21:07:18.450597378 +0100
@@ -9,7 +9,7 @@
 rm -fr TRACE.sym TRACE.mpits set-0

 #export EXTRAE_HOME=`cat ../../../PREFIX`
-export EXTRAE_HOME=$(top_builddir)
+export EXTRAE_HOME=${top_builddir}

 if test ! -x ${EXTRAE_HOME}/bin/extrae ; then
    echo "Could not execute binary rewriter test because ${EXTRAE_HOME}/bin/extrae has not been installed. Run make install first."
diff -rN -u old/tests/functional/launcher/test-dyninst-2.sh new/tests/functional/launcher/test-dyninst-2.sh
--- old/tests/functional/launcher/test-dyninst-2.sh 2018-09-24 21:07:18.350597378 +0100
+++ new/tests/functional/launcher/test-dyninst-2.sh 2018-09-24 21:07:18.450597378 +0100
@@ -9,7 +9,7 @@
 rm -fr TRACE.sym TRACE.mpits set-0

 #export EXTRAE_HOME=`cat ../../../PREFIX`
-export EXTRAE_HOME=$(top_builddir)
+export EXTRAE_HOME=${top_builddir}

 if test ! -x ${EXTRAE_HOME}/bin/extrae ; then
    echo "Could not execute binary rewriter test because ${EXTRAE_HOME}/bin/extrae has not been installed. Run make install first."
diff -rN -u old/tests/functional/launcher/test-dyninst.sh new/tests/functional/launcher/test-dyninst.sh
--- old/tests/functional/launcher/test-dyninst.sh   2018-09-24 21:07:18.350597378 +0100
+++ new/tests/functional/launcher/test-dyninst.sh   2018-09-24 21:07:18.450597378 +0100
@@ -9,7 +9,7 @@
 rm -fr TRACE.sym TRACE.mpits set-0

 #export EXTRAE_HOME=`cat ../../../PREFIX`
-export EXTRAE_HOME=$(top_builddir)
+export EXTRAE_HOME=${top_builddir}

 if test ! -x ${EXTRAE_HOME}/bin/extrae ; then
    echo "Could not execute binary rewriter test because ${EXTRAE_HOME}/bin/extrae has not been installed. Run make install first."