Refactor `mixed_canonize!`

bsc-quantic / Qrochet.jl

Quantum Tensor Networks

https://bsc-quantic.github.io/Qrochet.jl/

Apache License 2.0

1 stars 0 forks source link

Refactor `mixed_canonize!` #14

Closed mofeing closed 7 months ago

mofeing commented 7 months ago

I just discovered some things from #10 that wasn't convinced about.

mode kwarg in canonize_site! would be better named as method
There are redundant factorizations in mixed_canonize!

Something not yet addressed in this PR is that if we use the :svd method in canonize_site!, then we cannot properly mixed-canonize a Chain without also contracting the "spectrum vector" with the next tensor.

mofeing commented 7 months ago

The CI is failing because some weird interaction with the master version of Tenet. Merging because all tests pass in my computer.