search

bsc-quantic / Tenet.jl

Composable Tensor Network library in Julia
https://bsc-quantic.github.io/Tenet.jl/
Apache License 2.0
19 stars 1 forks source link

Fix excessive synchronization in `contract` on `Dagger.DArray` #124

Closed mofeing closed 4 months ago

mofeing commented 10 months ago

Closes #123

Todorbsc commented 10 months ago

Can we add some tests? :)

Yeah, we should. Currently, we are trying to fix some things in order to make the code work.

codecov[bot] commented 10 months ago

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 80.46%. Comparing base (c2ef9db) to head (8129c7e). Report is 18 commits behind head on master.

:exclamation: Current head 8129c7e differs from pull request most recent head 7231b46

Please upload reports for the commit 7231b46 to get more accurate results.

Files Patch % Lines
ext/TenetDaggerExt.jl 0.00% 56 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #124 +/- ## ========================================== + Coverage 79.30% 80.46% +1.16% ========================================== Files 17 11 -6 Lines 865 640 -225 ========================================== - Hits 686 515 -171 + Misses 179 125 -54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mofeing commented 4 months ago

Updated the code to the last Tenet and Dagger changes. Also it now calls Tenet.contract instead of OMEinsum.EinCode.

@jofrevalles I also added some tests.