search

bsc-quantic / Tenet.jl

Composable Tensor Network library in Julia
https://bsc-quantic.github.io/Tenet.jl/
Apache License 2.0
17 stars 1 forks source link

Fix from last PR: bug in plot functions #28

Closed jofrevalles closed 1 year ago

jofrevalles commented 1 year ago

Small fix from last PR, the plot function crashed since the function labels conflicts with the keyword argument labels.

mofeing commented 1 year ago

This bug wasn't catch by tests because we don't test visualization. Maybe we should think about testing that plotting doesn't crash?

jofrevalles commented 1 year ago

Yep, my fault. Since this was added by code suggestion, I did not test that. I will next time.

mofeing commented 1 year ago

No worries! It was actually my fault because I requested that change. I'm just commenting that maybe we should find a way to test that.

jofrevalles commented 1 year ago

We could do a normal test for that, right? Just to see if the plot is at least able to open without crashes.

mofeing commented 1 year ago

Maybe yeah. The only thing is that CI runs do not have a graphical interface so they probably will fail. I think there is a package for creating a fake graphical interface just for this kind of things.