Closed jofrevalles closed 1 year ago
The way you have written the code won't work because it implies that the type of all the elements in a Sequence
(which is just a helper alias for Union{Tuple,Vector}
.
Also, the PR fails an Aqua test.
I've refactored the code in such a way that it solves these problems and also abstract the call to transform!
in a better way.
Also, I've added some tests for theses cases.
Summary
This PR addresses the bug found in the
transform
function. This bug was not found before because this function is not included in the tests at the moment. Previously, we could not call thetransform
function since thetransformations
argument accepted the typeSequence{Transformation}
andTransformation
is an abstract type. This is now changed so it accepts aSequence
ofstruct
s that inherit fromTransformation
.Example
Although this may be counter-intuitive since the
transform!
function is called with:What do you think, @mofeing ?