search

bscan / PerlNavigator

Perl Language Server that includes syntax checking, perl critic, and code navigation
MIT License
198 stars 39 forks source link

namespace::autoclean update issues #102

Closed Scimon closed 11 months ago

Scimon commented 11 months ago

I updated Perl Navigator on VSCode this morning to version 0.7.7 and started getting compilation errors in code that was working fine before the update and only in VSCode. These errors seem to be because the DateTime module is expecting a version of namespace::autoclean.

Again I can use DateTime (and namespace::autoclean with versioning) outside VSCode it's just breaking internally. I noticed the changelog for yesterday included a mention of namespace::autoclean and I wonder if the fix for that may have broken it's usage in code with versioning?

Scimon commented 11 months ago

I've rolled back to 0.7.4 for now. (The bug does seem to have come in with 0.7.5 which is where the update to namespace::autoclean is mentioned).

pders01 commented 11 months ago

Noticed exactly the same behaviour.

bscan commented 11 months ago

Hi @Scimon and @pders01, sorry about that and thank you for reporting the issue. namespace::clean and namespace:autoclean had been giving me trouble regarding interactions the symbol table because they both delete elements from the table before I can inspect it.

I just pushed out another version of the Navigator (0.7.8) that tries to work around these issues by faking a version of clean/autoclean, which now works for me on loading DateTime. Let me know if you see any other issues. Thanks!

Scimon commented 11 months ago

I'll give it a shot now.

Scimon commented 11 months ago

That's look good now. Thanks for the speedy response!

pders01 commented 11 months ago

Seconded! Also great new features. Thanks for your work @bscan.

bscan commented 11 months ago

Great, thank you both!