Support of 1 Fast-Math Flag

bscarlet / llvm-general

Rich LLVM bindings for Haskell (with transfer of LLVM IR to and from C++, detailed compilation pass control, etc.)

http://hackage.haskell.org/package/llvm-general

132 stars 38 forks source link

Support of 1 Fast-Math Flag #96

Closed tvh closed 10 years ago

tvh commented 10 years ago

I implemented the Support for Fast-Math-Flags. #90 This Patch adds the 'fast' flag for the relevant Operations.

bscarlet commented 10 years ago

This is a great start, but it needs some more work. I'll get to it at some point soon (hopefully), but if you're interested in doing more...

The tests need to build without warnings - there are some uses of the instructions you changed that need a setting for the flag.
There needs to be some testing that the AST handling of the flag works right - cases in the Instruction tests that handle both values of the flags.
The constant expressions corresponding to the instructions need the flag too, with tests also.

With that much I'd to merge this PR without additional changes, but I'd also want to handle the other flags before I push a version up to hackage.

Thanks!

bscarlet commented 10 years ago

I take it back about the constant expressions. They don't seem to have corresponding flags. How odd.

tvh commented 10 years ago

Now all flags are supported. The existing tests should build now.

tvh commented 10 years ago

Are you okay with the changes? As far as I can tell all flags work.

bscarlet commented 10 years ago

I've been refactoring to make your code fit my conventions better, but my time's been a little limited. Hopefully I'll get a version with the feature up soon.

On Mar 31, 2014, at 1:55 AM, Timo von Holtz notifications@github.com wrote:

Are you okay with the changes? As far as I can tell all flags work.

— Reply to this email directly or view it on GitHub.

bscarlet commented 10 years ago

My refactored version is now checked in. Thanks for getting this functionality going.