search

bschilder / ThreeWayTest

Summary statistics-based association test for identifying the pleiotropic effects with set of genetic variants
2 stars 1 forks source link

Codecov not recognizing tests #19

Closed bschilder closed 1 year ago

bschilder commented 1 year ago

Codecov coverage is not updating: Screenshot 2023-03-03 at 12 28 34

For whatever reason, the coverage tests are not being run by Codecov. It's possible this is simply a bug on their end as I noticed there were recently other issues regarding the rendering of coverage badges (which were showing up as "not found" despite having coverage data on the associate Codecov page): https://app.codecov.io/gh/bschilder/ThreeWayTest/tree/master/R

It's also possible that something has gone awry with the test/upload code coverage steps in rworkflows: https://github.com/neurogenomics/rworkflows/blob/24ca1e99062b52d03b78bcf2eec869cd7d2e189f/action.yml#L313

If this doesn't resolve itself soon, I'll continue looking into it further.

bschilder commented 1 year ago

Figured it out! Somehow the tests/testthat.R went missing and thus unit tests were not actually being run.

Screenshot 2023-03-08 at 11 46 44

Just pushed to retrigger code coverage tests, but based on my local run ThreeWayTest has a whopping 100%! This is usually rather hard to achieve and ensure that your package will work robustly across a wide variety of scenarios. @ftdbdl

devtools::test_coverage()

Screenshot 2023-03-08 at 12 10 48

ftdbdl commented 1 year ago

Sorry I miss the first comment! I will further check our package and make sure it works robustly across a wide variety of scenarios.

bschilder commented 1 year ago

Sorry I miss the first comment! I will further check our package and make sure it works robustly across a wide variety of scenarios.

No worries, this one was stumping me until I noticed the missing file just now. But things are looking really good now!