bschlenk / homebridge-roku

Control your Roku media player from your iOS devices using Apple's HomeKit.
MIT License
78 stars 24 forks source link

Home icon instead of TV icon, for Roku TV #202

Open LordZork opened 3 years ago

LordZork commented 3 years ago

Hi, I was using the homebridge-roku-tv plugin, until my device (Roku TV) started showing as "unresponsive," which required frequent restarting of Homebridge to resolve. Being that this has been an issue for a while now, with no update/fix, I switched to this plugin. It was easy to setup, but unfortunately my device (Roku TV) shows – in the Home app – with a house icon instead of the TV icon. Is there any way to fix this, so that my TV – as it did with the other plugin – will show up with the TV icon?

LordZork commented 3 years ago

Whoops, I didn't realize there was already an open issue for this, as it is titled Update for iOS 14 (issue #175).

NateUT99 commented 3 years ago

If your TV can support the latest 9.4 release, you can just use that and get official homekit support now... including the correct icon. 😉

jestech commented 3 years ago

If your TV can support the latest 9.4 release, you can just use that and get official homekit support now... including the correct icon. 😉

The official support implementation is not the best. It doesn't list the installed Apps and sometimes HomeKit says the TV is on when it isn't. Roku did a poor job implementing HomeKit.

NateUT99 commented 3 years ago

If your TV can support the latest 9.4 release, you can just use that and get official homekit support now... including the correct icon. 😉

The official support implementation is not the best. It doesn't list the installed Apps and sometimes HomeKit days the TV is on when it isn't. Roku did a poor job implementing HomeKit.

100% agree, it annoys me to see the phantom “on” TVs. If I could figure out how to setup the beta version of this, I’d likely move back (although I arguably don’t really use the functionality much outside of automations).

jestech commented 3 years ago

@NateUT99 I spent a good amount of time trying to make the beta version work to no success 😢. It seems as if things have changed so much it is not ready yet. I couldn't get call homebridge-roku-config because somehow it is not registering. Tried copying my v3 config but it doesn't work. I ran out of ideas. So, sadly, back to Roku's HomeKit official support.

NateUT99 commented 3 years ago

@NateUT99 I spent a good amount of time trying to make the beta version work to no success 😢. It seems as if things have changed so much it is not ready yet. I couldn't get call homebridge-roku-config because somehow it is not registering. Tried copying my v3 config but it doesn't work. I ran out of ideas. So, sadly, back to Roku's HomeKit official support.

I was digging around in the v4 beta files and found that I was able to get both of my Roku-based TCL TVs to appear after adding this to my HomeBridge config file. After restart, you should see entries in the log telling you to add the detected television(s) to your HomeKit setup. I did some quick testing and everything seems to be working as expected, so I have disabled the native AirPlay/HomeKit support.

"platforms": [ { "platform": "RokuPlatform", "name": "Roku", "discoverTimeout": 5000, "volumeIncrement": 5, "volumeDecrement": 1, "infoButtonOverride": "HOME" }

jestech commented 3 years ago

@NateUT99 How did you manage to get the rest of the config file entries? Do you have any entries for the accessories section of the config file as is in homebridge/config-sample.json? On v3 I had to run homebridge-roku-config to get those, something I can't do on v4.

bschlenk commented 3 years ago

Hey, I haven’t had much time to write up migration docs for v4, I’ll get around to that eventually.

v4 doesn’t require you to tell it the Roku devices up front, so homebridge-roku-config isn’t necessary anymore. It’ll discover your TVs automatically - you then have to manually add them to your home app.

You can read through the config schema to see what options you can configure.

jestech commented 3 years ago

Hey, I haven’t had much time to write up migration docs for v4, I’ll get around to that eventually.

v4 doesn’t require you to tell it the Roku devices up front, so homebridge-roku-config isn’t necessary anymore. It’ll discover your TVs automatically - you then have to manually add them to your home app.

You can read through the config schema to see what options you can configure.

Hi, @bschlenk thanks for getting back to us! 🙂 Appreciate you taking the time to develop this plugin. 🙏🏼

I tried installing v4 then opened on to the Home App, typed in the Homebridge code but no device was added. I only see my TV but coming from the official HomeKit support. Am I missing something?

bschlenk commented 3 years ago

@jestech You have to manually add it following these instructions: https://github.com/homebridge/homebridge/wiki/Connecting-Homebridge-To-HomeKit#how-to-add-homebridge-cameras--tvs

jestech commented 3 years ago

@bschlenk those are the steps I’m following 😢. When I tap I Don't Have a Code or Cannot Scan only one TV “available to Add” pops up which, if I tap it, triggers the official HomeKit setup of RokuOS and if I enter the Homebridge code instead the Add fails. 😭

NateUT99 commented 3 years ago

@bschlenk those are the steps I’m following 😢. When I tap I Don't Have a Code or Cannot Scan only one TV “available to Add” pops up which, if I tap it, triggers the official HomeKit setup of RokuOS and if I enter the Homebridge code instead the Add fails. 😭

Did you also check to include the settings I posted? I noticed that the values were shown in the config-ui-x GUI but they weren’t in the actual config file so I manually added it and it started working.

I'd probably also go in and disable the native HomeKit configuration in the TV setup too before trying to add the HB ones (just to keep it simple).

jestech commented 3 years ago

@NateUT99 You were totally right! I finally got time to try it and your solution did the job! Yes, for some reason the platform entry was empty as you said. I copied the parameters you initially posted here and it worked! AirPlay is still turned on in my case. Thanks so much! 🙏🏼