search

bschmitt / laravel-amqp

AMQP wrapper for Laravel and Lumen to publish and consume messages
MIT License
268 stars 86 forks source link

Consider using queue interprop as abstraction for queues #35

Open makasim opened 6 years ago

makasim commented 6 years ago

Hello!

Please look at https://github.com/queue-interop/queue-interop project. Using interfaces from it allows us reuse some implementations like enqueue, which supports a lot of transports. You can outsource some code

stevenklar commented 5 years ago

As we use the default php library mentioned by rabbitmq themself (php-ampqlib) this might a breaking change and could conflict with future changes.

@makasim Could you give an example which interfaces you would exchange?

makasim commented 5 years ago

@stevenklar I am talking about amqp-interop interfaces, There are impl for php-amqplib, bunny and amqp-ext.

Please, check official php-amqplib tutorials ported to amqp interop.

makasim commented 5 years ago

All three mentioned transports support message delaying out of the box, unified ssl configuration and DSN

stevenklar commented 5 years ago

@makasim Would you consider implementing those interfaces and open a pull request?

After a short review this seems like a bigger refactoring.